Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lazy aggregated_by #3280

Closed
zklaus opened this issue Feb 25, 2019 · 3 comments · Fixed by #3281
Closed

Add lazy aggregated_by #3280

zklaus opened this issue Feb 25, 2019 · 3 comments · Fixed by #3281
Assignees
@bjlittle
Labels
Release: Minor Type: Enhancement Type: Performance
Milestone
v2.3.0

Comments

@zklaus
Copy link

zklaus commented Feb 25, 2019

At the moment, collapsed is the only lazy statistics method. It would be useful to also have aggregated_by in a lazy version, i.e. allow for the use of lazy aggregators.

This touches on #2418, and #2928.
zklaus pushed a commit to zklaus/iris that referenced this issue Feb 25, 2019
Adds lazy version of aggregated_by routine to Cube.
58d5c30 
Closes SciTools#3280

Signed-off-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
@zklaus zklaus mentioned this issue Feb 25, 2019
Merged
@valeriupredoi
Copy link

any chance collapsed with kwargs alike weights can be converted to lazy as well? There are really large differences in performance between collapsing with/without weights, see https://github.com/ESMValGroup/ESMValTool/issues/887 (my apologies if this comment is slightly off-topic)

@zklaus
Copy link
Author

zklaus commented Feb 27, 2019

@valeriupredoi I can definitely have a look. But first this needs to be finished.

@valeriupredoi
Copy link

absolutely - I will actually have a talk with @bjlittle about this (and other iris stuffs) on Monday 🍺

@bjlittle bjlittle added this to the v2.3.0 milestone Mar 4, 2019
@bjlittle bjlittle self-assigned this Mar 4, 2019
@bjlittle bjlittle mentioned this issue Mar 6, 2019
Closed
@pp-mo pp-mo added the votable label May 1, 2019
zklaus pushed a commit to zklaus/iris that referenced this issue Jul 11, 2019
Adds lazy version of aggregated_by routine to Cube.
5793592 
Closes SciTools#3280

Signed-off-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
@bouweandela bouweandela mentioned this issue Sep 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjlittle bjlittle

Labels
Release: Minor Type: Enhancement Type: Performance
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

Adds lazy version of aggregated_by routine to Cube. zklaus/iris
4 participants
@zklaus @bjlittle @pp-mo @valeriupredoi