-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MEAN with weights lazy #3299
Conversation
I have just signed the CLA. |
there should be no conflicts on version since I have been using |
also linking the original ESMValTool issue so we can close that when this gets merged https://github.com/ESMValGroup/ESMValTool/issues/887 |
I'm assuming (not knowing offhand) that dask doesn't have any excessively complex dependencies of it's own? Just thinking of installs on older platforms like EL7, SLES11, etc. |
The dask unit tests are running on Travis with Trusty Tahr, released in 2014, but they use conda to install their dependencies. |
The iris unit tests are also failing for the master branch. |
@bouweandela Could you rebase please? We've now merged back out |
9f97d2b
to
7125ff0
Compare
@bouweandela I'm going to make a PR on your branch (for this PR) to add some tests, is that okay? |
Sure! I hadn't realized that there were separate tests for lazy and non-lazy operators. |
greetings iris peeps 😁 Is this going to be part of the |
Closes #3129
Note that this does require at least version 1.1.0 of dask, I'm not sure if that is something you want.