Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature branch mesh-data-model #3996

Merged
merged 6 commits into from
Feb 10, 2021

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description

This PR updates the mesh-data-model feature branch with the latest commits from master.


Consult Iris pull request check list

pp-mo and others added 6 commits February 8, 2021 11:20
Co-authored-by: stephen.worsley <stephen.worsley@metoffice.gov.uk>
…ols#3989)

* Added text to state the Python version used to build the docs.

* Added footer template that includes the Python version used to build.

* added new line

* Review actions

* added whatsnew
* support for py38

* update CI and noxfile

* enforce alphabetical xml element attribute order

* full tests for py38 + fix docs-tests

* add whatsnew entry

* update doc-strings + review actions

* Alternate xml handling routine (#29)

* all xml tests pass for nox tests-3.8

* restored docstrings

* move sort_xml_attrs

* make sort_xml_attrs a classmethod

* update sort_xml_attr doc-string

Co-authored-by: Bill Little <bill.james.little@gmail.com>

* add jamesp to whatsnew + minor tweak

Co-authored-by: James Penn <james@jamespenn.co.uk>
@trexfeathers
Copy link
Contributor

Although I haven't looked yet, I expect #3976 to have ramifications for the new Connectivity class since it includes an older style XML representation.

@bjlittle
Copy link
Member Author

bjlittle commented Feb 10, 2021

@trexfeathers Actually, no it doesn't, thankfully. The final changes banked for #3976 don't require any reworking of xml_element methods 👍 ... thanks to @jamep 🍻

@pp-mo pp-mo merged commit 1c699a3 into SciTools:mesh-data-model Feb 10, 2021
@bjlittle
Copy link
Member Author

@pp-mo Thanks 🎉

@bjlittle bjlittle deleted the update-mesh-data-model branch February 10, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants