Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unit/fileformats/__init__ #5863

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Mar 19, 2024

Move this code into pp_load_rules where it belongs.
While converting just these test routines into assertion routines

Because it's simpler to do that first, before converting all the pp_load_rules tests themselves.

NOTE:
I subsequently discovered that one of these 2 routines is specific to a single test, so it can go there.
But we may as well do it this way this first, anyway.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pp-mo I understand the need for reshuffle here, thanks.

@bjlittle bjlittle merged commit e2ea7aa into SciTools:FEATURE_pytest_conversion Mar 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants