Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining graphics tests to PyTest #5867

Conversation

trexfeathers
Copy link
Contributor

ruff check --select=PT compliant

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (2e18ae8) to head (76482c5).
Report is 15 commits behind head on FEATURE_pytest_conversion.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           FEATURE_pytest_conversion    #5867      +/-   ##
=============================================================
- Coverage                      89.74%   89.68%   -0.07%     
=============================================================
  Files                             92       92              
  Lines                          22940    22940              
  Branches                        5462     5462              
=============================================================
- Hits                           20588    20573      -15     
- Misses                          1620     1639      +19     
+ Partials                         732      728       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is personal preference, otherwise happy with all the changes!

@ESadek-MO ESadek-MO merged commit 64b47fc into SciTools:FEATURE_pytest_conversion Mar 21, 2024
22 checks passed
@trexfeathers trexfeathers deleted the test_check_graphic_pytest branch May 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants