Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for making a new release #94

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

spencerkclark
Copy link
Member

🚀 Pull Request

This PR adds a section of the documentation that outlines the steps for making a release of nc-time-axis. This is just a draft of the steps I expect to follow to make the 1.4.0 release. It is based on my reading of the Iris release documentation, and my observations of how the 1.3.0 release was made.

I agree with @bjlittle that it would be nice to have these included in the documentation, so that we follow a common procedure. It would be great to get some feedback on these proposed steps before I go forward with things. Note that I am particularly inexperienced with conda-forge, so it would be good to make sure I have the correct understanding there.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #94 (cc7ff0c) into main (712670f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files           1        1           
  Lines         194      194           
  Branches       44       44           
=======================================
  Hits          183      183           
  Misses          6        6           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712670f...cc7ff0c. Read the comment docs.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @spencerkclark. Some comments inline for you.

docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Show resolved Hide resolved
docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Outdated Show resolved Hide resolved
@spencerkclark
Copy link
Member Author

Thanks for the helpful review comments @trexfeathers! I agree with all of your suggestions and made changes accordingly. Please let me know if you have any more thoughts.

@trexfeathers
Copy link
Contributor

LGTM, thanks @spencerkclark

@trexfeathers trexfeathers merged commit 9411c21 into SciTools:main Oct 21, 2021
@spencerkclark spencerkclark deleted the release-instructions branch October 21, 2021 12:36
@spencerkclark
Copy link
Member Author

Great, thanks @trexfeathers. I would like to carry out these steps to make the 1.4.0 release sometime in the near future. Would it be possible for me to be granted access to upload to PyPI for this project? My username there is "spencerkclark" (the same as my GitHub handle).

@trexfeathers
Copy link
Contributor

Would it be possible for me to be granted access to upload to PyPI for this project?

@spencerkclark this reveals a flaw in our current system! I've always been instructed to perform SciTools PyPI releases via a shared account, the credentials for which are held within a credentials manager only accessible within the UK Met Office. I expect it will be OK to grant access to other accounts but I'll check with my team first.

@spencerkclark
Copy link
Member Author

Thanks! In the worst case we can continue to have someone from the Met Office handle that part of the release process.

@rcomer
Copy link
Member

rcomer commented Oct 21, 2021

What happens at Cartopy? That’s been maintained by people outside the Met Office for a while now.

@spencerkclark
Copy link
Member Author

@bjlittle gave me permissions on PyPI, so I should be all set. I'm going forward with the release now. Thanks all for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants