Issue 1628 #1690
Issue 1628 #1690
Conversation
The removed code was too heavy. In Crowdcrafting for example it has to compute around 2500 SQL queries to analyze all the projects, which is too much. As we've now specific endpoints with pagination via JSON the pybossa theme could query them to show the data that anyone wants. This should make PYBOSSA much faster, specially for the front page.
|
@alexandermendes, @mialondon and @therealmarv I think this now fixes the issue #1628 but I've added a few extra improvements. Basically, I've removed from the home endpoint loading all the categories as well as the projects and their data. While for your project might be okay, in Crowdcrafting is generating around 2.5K SQL queries. We handle all of them via the background jobs, so the users do not see any impact, but when you don't the jobs running this is pretty bad (especially for first timers using PYBOSSA). My aim with these changes is to use the new API endpoints that will allow us to do whatever we want as we can query anything: leaderboards, categories, etc. Before merging I would love your feedback, as the homepage will be affected by this changes (not yours, as you're now running a full SPA). |
|
Ok cool, so basically We were taking advantage of this in a couple of places but that's fine - as you say we can use the other endpoints. |
|
That's why I wanted to ask first :-) I think we put a lot of login into the backend for this endpoint, and now that we have the other solution, we can built that logic in any way thanks to SPAs. If it's fine for you, we will work with it. |
|
The last commit just refactored more this endpoint. Please @alexandermendes take a look before we break anything for you. |
|
Yeah so basically it's fine, I think we only have 3 references to this endpoint at the moment so not much to check/replace! Thanks for asking/warning us 😄 |
|
In my opinion this is a step forward to a more future proof PYBOSSA. Remove that old code! Btw. do we mention breaking changes somewhere? We should for a few legacy users?! |
|
@therealmarv yes, we do via the version numbers. We can increase to version 2.8.0 and explain in the docs that this is the major change regarding how the frontend works. In any case, as we will be merging the changes in the default theme, everyone using it as their theme should update it as well. |
|
@alexandermendes I'll confirm with another group if this is working for them, and then merge it. We'll bump the version to 2.8.0 |
No description provided.