Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore dump_only fields with missing value in check_unknown_fields #19

Closed
wants to merge 3 commits into from
Closed

Ignore dump_only fields with missing value in check_unknown_fields #19

wants to merge 3 commits into from

Conversation

lafrech
Copy link
Collaborator

@lafrech lafrech commented Jul 7, 2016

This illustrates one of the alternatives described in #18.

If figured since I had the code written, I might as well send a PR.

I'd rather wait for your feedback before going any further (add tests, for instance).

@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 93.761% when pulling 8cac7cb on Nobatek:check_unknown_fields_ignore_dump_only_missing into 3c5a9cf on Scille:master.

@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 93.758% when pulling 4bce7dc on Nobatek:check_unknown_fields_ignore_dump_only_missing into 3c5a9cf on Scille:master.

@lafrech lafrech mentioned this pull request Jul 21, 2016
Closed
3 tasks
@touilleMan
Copy link
Member

touilleMan commented Sep 8, 2016 •
edited
Loading

Implemented in 857d730

@touilleMan touilleMan closed this Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lafrech @coveralls @touilleMan