Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend the previous patch to LexFSharp #111

Closed
rdipardo opened this issue Oct 24, 2022 · 2 comments
Closed

Amend the previous patch to LexFSharp #111

rdipardo opened this issue Oct 24, 2022 · 2 comments
Labels
committed Issue fixed in repository but not in release fsharp Caused by the fsharp (F#) lexer

Comments

@rdipardo
Copy link
Contributor

As belatedly observed in #110, the patch committed as bf913de lacked foresight regarding decimal literals that may improperly contain notation prefixes for other bases. This implements the needed correction, as explained here:

LexFSharp-amend-bf913de.patch.txt
@rdipardo
Copy link
Contributor Author

This augments the committed test cases with some invalid decimal literals:

Issue111-Tests.diff.txt

@nyamatongwe nyamatongwe added the fsharp Caused by the fsharp (F#) lexer label Oct 25, 2022
nyamatongwe pushed a commit that referenced this issue Oct 25, 2022
@rdipardo @nyamatongwe
#111 #110 F#: Disallow notation prefixes inside decimal literals
75fc919 
Amends bf913de
@nyamatongwe nyamatongwe added the committed Issue fixed in repository but not in release label Oct 26, 2022
@nyamatongwe
Copy link
Member

Included in 5.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
committed Issue fixed in repository but not in release fsharp Caused by the fsharp (F#) lexer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyamatongwe @rdipardo