Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VB.NET] Support for multiline strings #151

Closed
xv opened this issue Mar 17, 2023 · 2 comments
Closed

[VB.NET] Support for multiline strings #151

xv opened this issue Mar 17, 2023 · 2 comments
Labels
committed Issue fixed in repository but not in release visual basic Caused by the Visual Basic lexer

Comments

@xv
Copy link
Contributor

xv commented Mar 17, 2023

Hi! Support for multiline strings was added in VB.NET 14 (released in 2015).

I came across broken highlighting for one of my code files and saw that LexVB.cxx does not support multiline strings. So, naturally I forked and patched.

I have gated the support for the feature behind the property lexer.vb.strings.multiline for the sake of downstream compatibility, though I am not sure if something else is preferred.

Preview of the change:

Attached is a patch file containing the changes, including a test case for the feature.
vbnet14_multiline_str.patch

Thank you.
@nyamatongwe nyamatongwe added the visual basic Caused by the Visual Basic lexer label Mar 17, 2023
nyamatongwe pushed a commit that referenced this issue Mar 18, 2023
@xv @nyamatongwe
#151 Add support for VB.NET 14 multiline strings
e8f3fe0
@nyamatongwe nyamatongwe added the committed Issue fixed in repository but not in release label Mar 18, 2023
@nyamatongwe
Copy link
Member

Committed. Added a marker comment so that applications like SciTE can document the property.

@nyamatongwe
Copy link
Member

Included in release 5.2.5.

@zufuliu zufuliu mentioned this issue Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
committed Issue fixed in repository but not in release visual basic Caused by the Visual Basic lexer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyamatongwe @xv