Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix is_in_dir under Unix #5391

Merged
merged 3 commits into from
Feb 19, 2023
Merged

fix(core): Fix is_in_dir under Unix #5391

merged 3 commits into from
Feb 19, 2023

Conversation

niheaven
Copy link
Member

Description

Fix RegEx in is_in_dir() to support Unix /

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

rashil2000
rashil2000 reviewed Feb 19, 2023
View reviewed changes
lib/install.ps1 Outdated Show resolved Hide resolved
Add escape
fdc53bc 
Signed-off-by: 张晓南 <zhangxn@igwfmc.com>
@niheaven niheaven merged commit 32ca856 into develop Feb 19, 2023
@niheaven niheaven deleted the fix-is_in_dir branch February 19, 2023 15:56
@niheaven niheaven mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000