Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(update/uninstall): Remove items from PATH correctly #5833

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix(update/uninstall): Remove items from PATH correctly #5833

merged 2 commits into from
Mar 20, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Mar 20, 2024 •
edited
Loading

Description

Remove PATH correctly.

  • Handle '.' in env_rm_path
  • Remove correct dir if junction is used (a.k.a. remove ...\current instead of ...\x.x.x during updating

Motivation and Context

Relates to #4550

How Has This Been Tested?

Before:
image

After:
image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title fix(uninstall): Remove items from PATH correctly fix(update/uninstall): Remove items from PATH correctly Mar 20, 2024
chawyehsu
chawyehsu approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niheaven niheaven merged commit 3186fef into develop Mar 20, 2024
2 checks passed
@niheaven niheaven deleted the fix-env_rm_path branch March 20, 2024 09:17
@niheaven niheaven mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chawyehsu chawyehsu chawyehsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @chawyehsu