780 refactor shift the logic for checking win condition #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
approved these changes
Mar 25, 2024
| @@ -423,7 +409,6 @@ async function chatGptSendMessage( | |||
|
|
|||
| const chatResponse: ChatResponse = { | |||
| completion: finalToolCallResponse.gptReply.completion, | |||
| wonLevel: finalToolCallResponse.wonLevel, | |||
There was a problem hiding this comment.
I love how many places this has been removed from 🥳
| expect.objectContaining({ wonLevel: true }) | ||
| ); | ||
| }); | ||
| }); |
pmarsh-scottlogic
deleted the
780-refactor-shift-the-logic-for-checking-win-condition
branch
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the code that checks whether the user has won. It used to live within the
sendEmail, deep within the call stack for sending a chat message. I've brought it right out to the top level.Notes
checkLevelWinConditionandcheckSubjectAndBodyContainsfrom email.ts to a new file winCondition.ts.checkLevelWinConditionfromhandleChatToGPT.wonLevelno longer being passed all the way back up through the call stack.Checklist
Have you done the following?