DataLogger: replace DataLogger with Experimental.DataStreamer2
#4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swharden
changed the title
DataLogger with Experimental.DataStreamer2
|
@swharden Any comments on this PR? |
|
Hi @drolevar, this looks great! I was out of town for about a week then got behind on some other stuff so I've been away from ScottPlot for a few weeks and just now catching up 😅
This certainly makes things easier. Thanks for implementing this in a non-breaking way! I'm excited to see this will be in the next release 👍 |
jpgarza93
reviewed
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be enough to replace DataLogger with DataStreamer2.
The existing use cases should not be broken.
I've decided to put the new functionality into DataLogger and not DataStreamer because DataStreamer2 is actually based on DataLogger and the API is compatible.