#13 footer component #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmannis
approved these changes
Mar 26, 2021
src/components/footer.js
Outdated
| import { StaticQuery, graphql } from "gatsby" | ||
|
|
||
| const FooterContainer = styled.div` | ||
| background-color: #848484; |
There was a problem hiding this comment.
Can you pull these colors out into variables pease?
src/components/footer.js
Outdated
| } | ||
| ` | ||
|
|
||
| const FooterHeader = styled.div` |
There was a problem hiding this comment.
If this type style is used in multiple places, can you pull it out into a typography.js file please?
src/components/footer.js
Outdated
| } | ||
| ` | ||
|
|
||
| const AddressSection = styled.div` |
There was a problem hiding this comment.
This is a general trend for project organization in Scout rn:
component-name/
component.js
component-styles.js
<anything else related to the component>
When you get a lot of files this keeps stuff really easy to follow, would you mind organizing this way? Also, could you please keep the styles inside their own folder?
src/components/footer.js
Outdated
| <AddressSection> | ||
| 123 Lorem Ipsum Dolor Tempor Incididunt YZ, 12345 123-456-7890 | ||
| </AddressSection> | ||
| {/* <EmailText>{data.prismicFooter.data.email}</EmailText> */} |
There was a problem hiding this comment.
Can you drop this comment please?
src/components/footer.js
Outdated
| return ( | ||
| <a href={social.social_link}> | ||
| <SocialPlaceholder> | ||
| {/* <img src={social.social_icon.url} /> */} |
src/components/footer.js
Outdated
| <EmailSection> | ||
| <form> | ||
| <input | ||
| type="text" |
There was a problem hiding this comment.
Could you please add aria labels or names to these labels + forms? here is a nifty document
src/components/footer.js
Outdated
| </EmailSection> | ||
| </FooterMainContent> | ||
|
|
||
| {/* <BottomLinks> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lofi footer style and structure