Revert "Add Pre-send warning for 1.38.1 bug" #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca73c87.
Samq64
approved these changes
Jun 4, 2024
Hans5958
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Holding until v1.39.0 (see the relevant section on the docs).
|
Technically the next minor release was already released :P I would recommend removing the warning a few days from now, as most people will be getting the update |
|
Minor release = v1.39.0 (following SemVer here) I remember the lines that Chrome users are quite slow at adopting the updates (Chromebook users?), so it is why this has to hold a bit. |
Hans5958
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #450
Version 1.38.2 fixed this issue, so within a few days this pre-send warning doesn't make sense anymore.