make appName and appVersion show in request params #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello buddy, thanks for the feedback, PR are welcome ;) It should have worked using the one-liner init, it's weird, but I've no issues using two setter instead of that if it correctly do the job. Thanks, (Nice catch for yarn, I forgot adding it). |
|
yeah, its weird ...I can not figure out why.. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this great plugin.
I can't get
anandavin ga's request. After reading docs and tweaking a little, I finnaly got it work now, please check it whether I made a proper modification. or I just miss something.