-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to switch between screen and page views #21
Conversation
Thanks you very much for your contribution. I'll give a deep look on it at lunchbreak. :) Regards |
No problem. By the way, think would be a good idea to setup some testing automation. You can do that easily with Circle CI (my preferred option these days) but it's up to you |
Of course i'll, didn't took time for it because it was a little lib at first :p But now it has growth a bit, i'll think about it :) |
@tarciosaraiva I'm real noob with circleCI # Javascript Node CircleCI 2.0 configuration file
#
# Check https://circleci.com/docs/2.0/language-javascript/ for more details
#
version: 2
jobs:
build:
docker:
# specify the version you desire here
- image: circleci/node:7.10
# Specify service dependencies here if necessary
# CircleCI maintains a library of pre-built images
# documented at https://circleci.com/docs/2.0/circleci-images/
# - image: circleci/mongo:3.4.4
working_directory: ~/repo
steps:
- checkout
# Download and cache dependencies
- restore_cache:
keys:
- v1-dependencies-{{ checksum "package.json" }}
# fallback to using the latest cache if no exact match is found
- v1-dependencies-
- run: yarn install
- save_cache:
paths:
- node_modules
key: v1-dependencies-{{ checksum "package.json" }}
# run tests!
- run: yarn test Looks good to me, do you confirm ? EDIT :
Are you sure the dependencies are ok ? |
The file looks OK. The fact that it failed is probably related to a network issue at the time of the build. Have you tried running it again? |
OK looks like there was a problem with |
Nice it's working now :) Thanks you |
Hopefully this will address #13