Have the measurement unit depend on the timezone (which is based on the metadata coordinates).

[nicomiguelino]

Overview

• Resolves Modify the weather app so that the units (for the measurement unit) query param is dependent on the current location. #110

Screenshots

@StanIwan & @vpetersson Here are some screenshots of the weather app (across various locations).

Toronto

Vancouver

Mock data used

Here's a snippet from my mocked screenly.js:

const getCoordinates = (area) => {
  switch (area) {
    case 'San Francisco':
      return [
        '37.7749',
        '-122.4194'
      ]
    case 'Manila':
      return [
        '14.5995',
        '120.9842'
      ]
    case 'Dijon':
      return [
        '47.3220',
        '5.0415'
      ]
    case 'New York':
      return [
        '40.7128',
        '-74.0060'
      ]
    case 'Toronto':
      return [
        '43.6532',
        '-79.3832'
      ]
    case 'Vancouver':
      return [
        '49.2827',
        '-123.1207'
      ]

    default:
      return []
  }
}

const screenly = {
  metadata: {
    coordinates: getCoordinates('Vancouver'),
    hardware: 'Screenly Player Max',
    hostname: 'srly-abcdefghijklmno',
    location: 'San Francisco, USA',
    screen_name: 'Edge App Test',
    screenly_version: 'v1.0.0',
    tags: [
        'All Screens'
    ]
  },
  settings: {
    disable_analytics: false,
    ga_api_key: 'mcd0n4ld5',
    sentry_id: 'p4nd4expr355',
    // Make sure to obfuscate the OpenWeatherMap API key as well.
    openweathermap_api_key: '[redacted]',
  }
}

[vpetersson]

As per @StanIwan's comment on Slack, can you double check this with some locations in Canada to ensure it is using the right unit?

[nicomiguelino]

@vpetersson, it seems that the libraries being used are quite smart. Thanks @StanIwan for the feedback!

[StanIwan]

@nicomiguelino I might be terribly mistaken here, but shouldn't Toronto be in metric (C) instead of imperial units (F)?

[nicomiguelino]

Thanks, @StanIwan. I did a quick research as well to supplement your comments. It seems that Canada is using Celsius.
Here's some reference that I found - https://www.learnalberta.ca/content/kes/pdf/or_cf_math_ss_a_03_temp.pdf. (Don't have a more credible source at the moment).

Requesting for another review, @StanIwan and @vpetersson...

[vpetersson]

No, no. This is a slippery slope. Please find a library that can do this.

[StanIwan]

Is there a particular reason we want to tie time units to timezone instead of country?

[sergey-borovkov]

Is there a particular reason we want to tie time units to timezone instead of country?

how are timezone and countries correlated? A country might have a lot of timezones, no?

[vpetersson]

No, according to ChatGPT at least, there is no country that uses both. Thus mapping it to country would be fine. Yet, I want a library for this rather than a hard coded list (which can get long i guess).