fix(action): Only run dockerd-rootless.sh if told
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kurt-von-Laven
force-pushed
the
action
branch
4 times, most recently
from
48f55c8
to
3ceeee8
Compare
GitHub Actions made an unannounced change impacting how we determine whether the rootless Docker install script started the Docker daemon. Previously, "API listen on $XDG_RUNTIME_DIR/docker.sock" was present in the script's output if the Docker daemon was started, but this is no longer guaranteed. Running dockerd-rootless.sh when the Docker daemon has already been started results in an error, so only run it when the install script outputs an explicit instruction to do so.
Kurt-von-Laven
changed the title
Kurt-von-Laven
force-pushed
the
action
branch
2 times, most recently
from
bd0ba7d
to
17842b4
Compare
Kurt-von-Laven
changed the title
dockerd-rootless.sh if told
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions made an unannounced change impacting how we determine whether the rootless Docker install script started the Docker daemon. Previously,
"API listen on $XDG_RUNTIME_DIR/docker.sock"was present in the script's output if the Docker daemon was started, but this is no longer guaranteed. Runningdockerd-rootless.shwhen the Docker daemon has already been started results in an error, so only run it when the install script outputs an explicit instruction to do so.