Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Refactor #114

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Video Refactor #114

merged 4 commits into from
Aug 24, 2023

Conversation

TroyKomodo
Copy link
Member

Proposed changes

We are refactoring the mono repo so that we can make way for a video pipeline solution.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #114 (da10fcc) into feature/website (329d0ef) will decrease coverage by 18.93%.
Report is 35 commits behind head on feature/website.
The diff coverage is 79.48%.

❗ Current head da10fcc differs from pull request most recent head f9d8fb9. Consider uploading reports for the commit f9d8fb9 to get more accurate results

@@                 Coverage Diff                  @@
##           feature/website     #114       +/-   ##
====================================================
- Coverage            81.98%   63.05%   -18.93%     
====================================================
  Files                   41      236      +195     
  Lines                 1393    20546    +19153     
====================================================
+ Hits                  1142    12956    +11814     
- Misses                 251     7590     +7339     
Files Changed Coverage Δ
common/src/signal.rs 93.10% <ø> (ø)
platform/api/src/database/channel_role.rs 0.00% <0.00%> (ø)
platform/api/src/database/channel_role_grant.rs 0.00% <0.00%> (ø)
platform/api/src/database/chat_message.rs 0.00% <0.00%> (ø)
platform/api/src/database/global_role_grant.rs 0.00% <0.00%> (ø)
platform/api/src/database/stream_bitrate_update.rs 0.00% <0.00%> (ø)
config/config/src/error.rs 25.30% <25.30%> (ø)
platform/api/src/database/stream_event.rs 33.33% <33.33%> (ø)
platform/api/src/database/protobuf.rs 43.33% <43.33%> (ø)
platform/api/src/database/stream.rs 47.61% <47.61%> (ø)
... and 56 more

... and 182 files with indirect coverage changes

@TroyKomodo TroyKomodo changed the base branch from main to feature/website August 24, 2023 22:09
@TroyKomodo TroyKomodo marked this pull request as ready for review August 24, 2023 22:44
@TroyKomodo TroyKomodo requested review from a team as code owners August 24, 2023 22:44
@TroyKomodo TroyKomodo merged commit 4bf9c5e into feature/website Aug 24, 2023
1 of 3 checks passed
@TroyKomodo TroyKomodo deleted the troy/video-refactor branch August 24, 2023 22:44
lennartkloock pushed a commit to lennartkloock/scuffle that referenced this pull request Aug 24, 2023
* feat: video refactor

* fix: removals

* fix: build

* fix: reformat
lennartkloock pushed a commit to lennartkloock/scuffle that referenced this pull request Aug 24, 2023
* feat: video refactor

* fix: removals

* fix: build

* fix: reformat
lennartkloock pushed a commit to lennartkloock/scuffle that referenced this pull request Aug 24, 2023
* feat: video refactor

* fix: removals

* fix: build

* fix: reformat
TroyKomodo added a commit that referenced this pull request Aug 24, 2023
* feat: video refactor

* fix: removals

* fix: build

* fix: reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant