-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Refactor #114
Merged
Merged
Video Refactor #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/website #114 +/- ##
====================================================
- Coverage 81.98% 63.05% -18.93%
====================================================
Files 41 236 +195
Lines 1393 20546 +19153
====================================================
+ Hits 1142 12956 +11814
- Misses 251 7590 +7339
|
TroyKomodo
force-pushed
the
troy/video-refactor
branch
from
August 22, 2023 22:03
e6d99ee
to
28d253f
Compare
TroyKomodo
force-pushed
the
troy/video-refactor
branch
from
August 24, 2023 22:17
7e1f036
to
1047cc5
Compare
lennartkloock
pushed a commit
to lennartkloock/scuffle
that referenced
this pull request
Aug 24, 2023
* feat: video refactor * fix: removals * fix: build * fix: reformat
lennartkloock
pushed a commit
to lennartkloock/scuffle
that referenced
this pull request
Aug 24, 2023
* feat: video refactor * fix: removals * fix: build * fix: reformat
lennartkloock
pushed a commit
to lennartkloock/scuffle
that referenced
this pull request
Aug 24, 2023
* feat: video refactor * fix: removals * fix: build * fix: reformat
TroyKomodo
added a commit
that referenced
this pull request
Aug 24, 2023
* feat: video refactor * fix: removals * fix: build * fix: reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We are refactoring the mono repo so that we can make way for a video pipeline solution.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.