Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): integrate video #170

Merged
merged 45 commits into from
Jan 5, 2024

Conversation

lennartkloock
Copy link
Member

Proposed changes

Integrate video pipeline into platform.

  • Integrate new player
  • Handle video events
  • Call video grpc endpoints from platform api

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #120

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 1101 lines in your changes are missing coverage. Please review.

Comparison is base (fa5418c) 73.83% compared to head (4f7a941) 47.72%.
Report is 54 commits behind head on feature/website.

❗ Current head 4f7a941 differs from pull request most recent head 0eea203. Consider uploading reports for the commit 0eea203 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/website     #170       +/-   ##
====================================================
- Coverage            73.83%   47.72%   -26.11%     
====================================================
  Files                  221      459      +238     
  Lines                17608    27784    +10176     
====================================================
+ Hits                 13000    13261      +261     
- Misses                4608    14523     +9915     
Files Coverage Δ
common/src/context.rs 100.00% <100.00%> (ø)
common/src/dataloader/batch_loader.rs 100.00% <100.00%> (ø)
common/src/global.rs 100.00% <100.00%> (ø)
common/src/prelude/futures.rs 100.00% <100.00%> (ø)
config/derive/src/lib.rs 85.92% <ø> (ø)
config/src/error.rs 0.00% <ø> (ø)
config/src/key.rs 0.00% <ø> (ø)
config/src/lib.rs 0.00% <ø> (ø)
config/src/primitives.rs 0.00% <ø> (ø)
config/src/sources/cli.rs 0.00% <ø> (ø)
... and 32 more

... and 559 files with indirect coverage changes

@TroyKomodo TroyKomodo marked this pull request as ready for review January 1, 2024 02:11
@TroyKomodo TroyKomodo requested review from a team as code owners January 1, 2024 02:11
@TroyKomodo TroyKomodo force-pushed the lennart/integrate-video branch 3 times, most recently from 325c0ae to 826d6ac Compare January 1, 2024 20:35
@TroyKomodo TroyKomodo added video/api Issues related to the Video API video/player Issues related to the Video Player platform/api Issues related to the Platform API platform/website Issues related to the Platform Website labels Jan 2, 2024
@TroyKomodo TroyKomodo marked this pull request as draft January 2, 2024 15:51
@lennartkloock lennartkloock marked this pull request as ready for review January 5, 2024 01:02
platform/website/.env Outdated Show resolved Hide resolved
Copy link
Member

@TroyKomodo TroyKomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lennartkloock lennartkloock merged commit eb89932 into feature/website Jan 5, 2024
4 checks passed
@lennartkloock lennartkloock deleted the lennart/integrate-video branch January 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/api Issues related to the Platform API platform/website Issues related to the Platform Website video/api Issues related to the Video API video/player Issues related to the Video Player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate new player
3 participants