Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to hyper 1.0 and http 1.0 #174

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Conversation

TroyKomodo
Copy link
Member

Proposed changes

This commit bumps to hyper 1.0 & http 1.0 whilst also removing a bunch of unused deps.

The problem is that tonic does not support http 1.0 yet, but we migrated anyways. We had to get rid of routerify because it is a dead repo.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

This commit bumps to hyper 1.0 & http 1.0 whilst also removing a bunch
of unused deps.

The problem is that tonic does not support http 1.0 yet, but we migrated
anyways. We had to get rid of routerify because it is a dead repo.
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 497 lines in your changes are missing coverage. Please review.

Comparison is base (e303b01) 52.38% compared to head (c0e3885) 47.96%.

❗ Current head c0e3885 differs from pull request most recent head f08b86d. Consider uploading reports for the commit f08b86d to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/website     #174      +/-   ##
===================================================
- Coverage            52.38%   47.96%   -4.42%     
===================================================
  Files                  449      457       +8     
  Lines                27327    27691     +364     
===================================================
- Hits                 14316    13283    -1033     
- Misses               13011    14408    +1397     
Files Coverage Δ
config/derive/src/lib.rs 85.92% <ø> (ø)
config/src/error.rs 0.00% <ø> (ø)
config/src/key.rs 0.00% <ø> (ø)
config/src/lib.rs 0.00% <ø> (ø)
config/src/primitives.rs 0.00% <ø> (ø)
config/src/sources/cli.rs 0.00% <ø> (ø)
config/src/sources/env.rs 0.00% <ø> (ø)
config/src/sources/file/json.rs 0.00% <ø> (ø)
config/src/sources/file/mod.rs 0.00% <ø> (ø)
config/src/sources/file/toml.rs 0.00% <ø> (ø)
... and 24 more

@TroyKomodo TroyKomodo marked this pull request as ready for review January 1, 2024 02:11
@TroyKomodo TroyKomodo requested review from a team as code owners January 1, 2024 02:11
@TroyKomodo TroyKomodo merged commit 01c5bad into feature/website Jan 1, 2024
6 checks passed
@TroyKomodo TroyKomodo deleted the troy/deps branch January 1, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant