Troy/ffmpeg bindings #180
Merged
Troy/ffmpeg bindings #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TroyKomodo
force-pushed
the
troy/ffmpeg-bindings
branch
from
9655c3e
to
c882551
Compare
ffmpeg-next-io is a set of io utils for ffmpeg-next which allow for in-memory buffers to be used with ffmpeg-next.
With the new addition of the `ffmpeg-next-io` crate we can now do in-memory io with `ffmpeg-next`. Previously we needed to write the file to a temporary location and then clean it up after the job was complete. Now we can just buffer the entire file in memory and process it in place.
In this commit I removed the previous "safe" bindings `ffmpeg-next`. These bindings were riddled with errors and issues around memory safety and ownership. I have now manually rewritten the bindings for some of the functions we need. We still however use the `ffmpeg-sys-next` library. This library contains no user code but rather is entirely generated by `rust-bindgen`.
Add the ffmpeg bindings to the transcoder. Also refactor the transcoder main loop.
Add some helper utils to set a ffmpeg logging callback
TroyKomodo
force-pushed
the
troy/ffmpeg-bindings
branch
from
8b575dc
to
dee9bad
Compare
TroyKomodo
added a commit
that referenced
this pull request
Jan 9, 2024
*switch transcoder to use ffmpeg-c bindings - all operations are in-memory - fine grain control over the threads - fine grain control of memory usage all of this allows us to reduce the resource usage of encoding. *redesign transcoder internals allowing for a better scalable approach *fix bug in h265 sps, with calculating width and height *move away from ffmpeg-next "safe" bindings The bindings are riddled with mistakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of what you want to change here, to help the maintainers understand why we should accept this pull request. Be sure to link to the issue if it fixes a bug or resolves a feature request.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.