-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGDB Categories #189
Merged
Merged
IGDB Categories #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TroyKomodo
added
platform/api
Issues related to the Platform API
platform/image-processor
Issues related to the Platform Image Processor
labels
Jan 14, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/website #189 +/- ##
===================================================
- Coverage 46.40% 45.48% -0.92%
===================================================
Files 487 489 +2
Lines 31501 32133 +632
===================================================
- Hits 14618 14617 -1
- Misses 16883 17516 +633
|
TroyKomodo
force-pushed
the
troy/categories
branch
3 times, most recently
from
January 18, 2024 14:44
f0bb543
to
5ebe65c
Compare
lennartkloock
approved these changes
Jan 20, 2024
TroyKomodo
force-pushed
the
troy/categories
branch
from
January 20, 2024 17:15
316d834
to
711ae36
Compare
SputNikPlop
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform/api
Issues related to the Platform API
platform/image-processor
Issues related to the Platform Image Processor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fetch categories from IGDB
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.