Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chat links from Freenode to Libera.Chat #247

Merged
merged 1 commit into from
May 28, 2021

Conversation

AndrewKvalheim
Copy link
Member

@AndrewKvalheim AndrewKvalheim commented May 21, 2021

Re SeaGL/organization#125. Implementation notes:

_config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to update the chat URLs on years-old blog posts. Caveat visitor and whatnot

@AndrewKvalheim
Copy link
Member Author

Not necessary to update them, or not necessary to not update them?

@funnelfiasco
Copy link
Contributor

:-) I guess "not necessary to not update them". Put more correctly: I think we can ignore the old blog posts. De-parameterizing them means pointing folks to Freenode, which is where we won't be. If we just update config.yml to point to Libera, the old posts will still say Freenode, but at least the links will go to the right place.

@AndrewKvalheim
Copy link
Member Author

Okay consensus has it, we’ll rewrite old posts to say <a href="https://libera.chat/">Freenode</a>. It pains the archivist in me.

@nhandler
Copy link
Contributor

Okay consensus has it, we’ll rewrite old posts to say <a href="https://libera.chat/">Freenode</a>. It pains the archivist in me.

@AndrewKvalheim I feel your pain, but I also tend to agree with @funnelfiasco that keeping it simple is probably fine. But I also question, is this accurate? I know in a number of blog posts I've written, I didn't utilize these parameters. So I imagine those references to freenode will still link to freenode rather than libera.chat, right? And arguably, breaking the links back to freenode is probably safer ultimately for our users (who knows what will happen with the domain/network going forward).

@AndrewKvalheim
Copy link
Member Author

is this accurate?

The ~20 posts in fa9c023 are affected.

breaking the links back to freenode is probably safer ultimately for our users (who knows what will happen with the domain/network going forward).

This is a good point. I’d suggest unlinking the text rather than mis-linking it, though.

@AndrewKvalheim
Copy link
Member Author

Continuing that thought, if there really is a safety concern we should scrub all the posts, not just the parameterized ones.

@altsalt altsalt merged commit fd5dafc into SeaGL:master May 28, 2021
@AndrewKvalheim AndrewKvalheim deleted the libera-chat branch June 8, 2021 20:19
nhandler pushed a commit to nhandler/seagl.github.io that referenced this pull request Nov 22, 2021
Change chat links from Freenode to Libera.Chat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants