Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for set_def killing new_def #21

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

XmiliaH
Copy link
Collaborator

@XmiliaH XmiliaH commented Oct 29, 2023

Backport fix in PR #18 to chapters 2 and 3.

Copy link
Collaborator

@cliffclick cliffclick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cliffclick cliffclick merged commit 400948b into SeaOfNodes:main Oct 29, 2023
dibyendumajumdar pushed a commit that referenced this pull request Nov 1, 2023
* Backport fix for set_def killing new_def (#21)

* Use JDK 21

* Remove duplicate field in pom

* Enable GA test for pull requests

---------

Co-authored-by: XmiliaH <45106915+XmiliaH@users.noreply.github.com>
dibyendumajumdar pushed a commit that referenced this pull request Nov 1, 2023
* Backport fix for set_def killing new_def (#21)

* Use JDK 21

* Remove duplicate field in pom

* Enable GA test for pull requests

---------

Co-authored-by: XmiliaH <45106915+XmiliaH@users.noreply.github.com>
@XmiliaH XmiliaH deleted the backport-pr-18 branch November 3, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants