-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActiveValue::try_as_ref()
#2197
Conversation
Thanks. But is |
I think, it's a good name because it's consistent with the existing In my dependent codebase, this helper is called Overall, it's up to you. I'm ok with other names, as long as they don't contain For other examples in the ecosystem, you can check out the methods on async_graphql::MaybeUndefined. It's a similar |
Hey @Expurple, thanks for contributing!! Maybe sea-orm/src/entity/active_model.rs Lines 815 to 842 in c59e28f
|
Just choose any one name that you agree to merge, then I make the edit and you merge it. The final approve decision is up to you anyway. I've already listed some options and explained why I prefer |
Hey @tyt2y3, perhaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation!
🎉 Released In 1.0.0-rc.5 🎉Thank you everyone for the contribution! |
🎉 Released In 1.0.0 🎉Thank you everyone for the contribution! |
Another helper method that I use very often and would like to upstream. Basically, a non-panicking version of ActiveValue::as_ref.
PR Info
Closes
Dependencies:
Dependents:
New Features
ActiveValue::try_as_ref()
Bug Fixes
Breaking Changes
Changes