Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues-496 Add support FULL OUTER JOIN #497

Merged
merged 2 commits into from
Nov 15, 2022
Merged

issues-496 Add support FULL OUTER JOIN #497

merged 2 commits into from
Nov 15, 2022

Conversation

ikrivosheev
Copy link
Member

PR Info

Changes

  • Add support FULL OUTER JOIN

@billy1624
Copy link
Member

Please correct me if I am wrong:

MySQL doesn't support FULL OUTER JOIN, only Postgres and SQLite support it. We can still support FULL OUTER JOIN in SeaQuery but we should throw error if it's a MySQL query.

CC @itsAmitGoyani

@ikrivosheev
Copy link
Member Author

Please correct me if I am wrong:

MySQL doesn't support FULL OUTER JOIN, only Postgres and SQLite support it. We can still support FULL OUTER JOIN in SeaQuery but we should throw error if it's a MySQL query.

CC @itsAmitGoyani

@billy1624, yes! You are right...

@itsAmitGoyani
Copy link

@billy1624 Correct.

@ikrivosheev
Copy link
Member Author

ikrivosheev commented Nov 5, 2022 •
edited
Loading

@billy1624 @itsAmitGoyani Well, which behavior are we expect? panic in runtime? Or do we try to emulate the join type?

@ikrivosheev ikrivosheev self-assigned this Nov 5, 2022
@ikrivosheev
Copy link
Member Author

@billy1624 Done!

@ikrivosheev ikrivosheev force-pushed the feature/issues-496_full_outer_join branch 3 times, most recently from aae048c to 3862d0a Compare November 14, 2022 08:33
@ikrivosheev ikrivosheev force-pushed the feature/issues-496_full_outer_join branch from 3862d0a to 0d3e199 Compare November 14, 2022 08:58
billy1624
billy1624 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ikrivosheev, thanks for the refactoring!!

@ikrivosheev ikrivosheev merged commit 30dd6fb into SeaQL:master Nov 15, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-496_full_outer_join branch November 15, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need value 'FullOuterJoin' in 'JoinType' enum
3 participants
@ikrivosheev @billy1624 @itsAmitGoyani