Make OnConflict store both update_columns and values
#609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Hey @elbertronnie, thanks for contributing!! The implementation looks good to me :)
elbertronnie
force-pushed
the
fix-on-conflict
branch
from
10cb9ff
to
038ec9b
Compare
ikrivosheev
approved these changes
Mar 3, 2023
tyt2y3
reviewed
Mar 8, 2023
🎉 Released In 0.29.0 🎉Your participation is what makes us unique; your adoption is what drives us forward. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
OnConflict::valuesandOnConflict::update_columnsgets overridden by one another #593Breaking Changes
OnConflict::valuesandOnConflict::update_columnswill append the new values keeping the old values intact instead of erasing themChanges
OnConflictUpdatethat determines the column update strategy in ON CONFLICT expressionsUpdateColumnsandUpdateExprswithUpdate(Vec<OnConflictUpdate>)inOnConflictAction