Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sea-query): Fix clippy warnings on Rust 1.75 #729

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

siketyan
Copy link
Sponsor Contributor

PR Info

  • Closes N/A
  • Dependencies: N/A
  • Dependents: N/A

New Features

N/A

Bug Fixes

N/A

Breaking Changes

N/A

Changes

  • Fix clippy warnings introduced in Rust 1.75 toolchain

@@ -1,6 +1,7 @@
pub use expr::*;
pub use extension::*;
pub use func::*;
#[allow(unused_imports)]
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no exported members in interval module so clippy warns it, should we just remove this re-export or keep with #[allow] for future usages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case it's good to remove pub from pub use

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not used in the module, too.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, all code in the interval.rs is impl so we can remove this use.

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, removed entire the re-export in b94ea89

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 29, 2023

Thank you! You are so fast

@tyt2y3 tyt2y3 merged commit 9f7e199 into SeaQL:master Dec 29, 2023
20 checks passed
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@siketyan siketyan deleted the refactor/clippy-rust1.75 branch December 29, 2023 12:23
Copy link

github-actions bot commented Jan 1, 2024

🎉 Released In 0.30.6 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants