Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memguard for secrets #286

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

jfantinhardesty
Copy link
Contributor

@jfantinhardesty jfantinhardesty commented Jul 16, 2024

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Use memguard to store secrets, passphrases to prevent heap inspection attack. Now passphrases are stored in a memguard enclave and only retrieved immediately before they are used. This includes s3storage, azstorage, and using a passphrase to secure a config file.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

Copy link
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants