EOS-21367 Add puppet-agent for facter cli used in cortx-hare component

[vaibhavparatwar]

Signed-off-by: Vaibhav Paratwar vaibhav.paratwar@seagate.com

Specification of requested package

Details	Values
Package Name	puppet-agent
Version	puppet-agent-6.13.0-1.el7.x86_64
license	https://github.com/puppetlabs/puppet-agent/blob/main/LICENSE
Source	https://github.com/puppetlabs/puppet-agent

Please add below details about package

• Purpose of using new SW ?Hare requires facter version 3.14.8 or higher. In case when facter version is too low (like in this example), some more tricky problems can appear (EOS-15307 is an example what could happen and how much effort may be required to find the root cause).
• Location of the source code of new opensource SW ? https://github.com/puppetlabs/facter
• Did you evaluate existing SW and confirm they do not serve the purpose ? If yes, include the comparison. If no, why ? Currently in LR2 VM environment we already are using it.
• Who is building it or how it gets built ? If yes, Which component/rpm will it be included ? i.e. name of the rpm which includes SW.
• Download location of opensource software package ? https://github.com/puppetlabs/facter & http://mirror.grid.uchicago.edu/pub/puppet6/7/x86_64/
• Who will be supporting this package ? Puppet project
• Is there a configuration required for this? Who will be configuring it ? No i think @knekrasov correct me if I am wrong.
• Which component is responsible for deploying on nodes ? thrid party
• What is the licensing policy ? Is it approved by legal ? yes I think already we are using it in LR2 VM environment

[mukul-seagate11]

looks good

[shailesh-vaidya]

@vaibhavparatwar please provide facter >= 3.14.8 rpm package location. So that we can download and add it in CORTX third-party. Also please fill other details in description Purpose of using new SW ? etc. This will help get PR reviewed and approved faster.

[knekrasov]

@shailesh-vaidya here is a snippet of my yum provides facter at SSC VM:

puppet-agent-6.13.0-1.el7.x86_64 : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, and hiera.
Repo        : @EOS_Puppet6_puppet6-el7
Matched from:
Provides    : facter >= 1:3.0.0

$ rpm -qf $(readlink -f $(which facter))
puppet-agent-6.13.0-1.el7.x86_64
$ facter --version
3.14.8 (commit 4339472f441868ecdae694ffc71e7c8ed0fc24e3)

[shailesh-vaidya]

@shailesh-vaidya here is a snippet of my yum provides facter at SSC VM:

puppet-agent-6.13.0-1.el7.x86_64 : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, and hiera.
Repo        : @EOS_Puppet6_puppet6-el7
Matched from:
Provides    : facter >= 1:3.0.0

$ rpm -qf $(readlink -f $(which facter))
puppet-agent-6.13.0-1.el7.x86_64
$ facter --version
3.14.8 (commit 4339472f441868ecdae694ffc71e7c8ed0fc24e3)

@knekrasov Yes. So it's puppet-agent-6.13.0-1.el7.x86_64 package which is providing facter command line. So we may need to add puppet-agent package then. Not sure about license and other stuff for that.

[root@ssc-vm-rhev4-0045 ~]# which facter
/bin/facter

[root@ssc-vm-rhev4-0045 ~]# readlink /bin/facter
/opt/puppetlabs/bin/facter

[root@ssc-vm-rhev4-0045 ~]# rpm -q --whatprovides /bin/facter
file /bin/facter is not owned by any package
[root@ssc-vm-rhev4-0045 ~]# rpm -q --whatprovides /opt/puppetlabs/bin/facter
puppet-agent-6.13.0-1.el7.x86_64

[ujjwalpl]

Approving the patch.

Suggestion: The file name needs to change align with the conventions used across

• python-requirements.txt for direct dependencies
• python-requirements.ext.txt for indirect dependencies

[ujjwalpl]

Please ensure that download location and rpms are shard with the RE team.

[vaibhavparatwar]

Please ensure that download location and rpms are shard with the RE team.

Done. Updated the information of rpm download for puppet-agent (which provides facter 3.14.8).

[vaibhavparatwar]

@shailesh-vaidya here is a snippet of my yum provides facter at SSC VM:

puppet-agent-6.13.0-1.el7.x86_64 : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, and hiera.
Repo        : @EOS_Puppet6_puppet6-el7
Matched from:
Provides    : facter >= 1:3.0.0

$ rpm -qf $(readlink -f $(which facter))
puppet-agent-6.13.0-1.el7.x86_64
$ facter --version
3.14.8 (commit 4339472f441868ecdae694ffc71e7c8ed0fc24e3)

@knekrasov Yes. So it's puppet-agent-6.13.0-1.el7.x86_64 package which is providing facter command line. So we may need to add puppet-agent package then. Not sure about license and other stuff for that.

[root@ssc-vm-rhev4-0045 ~]# which facter
/bin/facter

[root@ssc-vm-rhev4-0045 ~]# readlink /bin/facter
/opt/puppetlabs/bin/facter

[root@ssc-vm-rhev4-0045 ~]# rpm -q --whatprovides /bin/facter
file /bin/facter is not owned by any package
[root@ssc-vm-rhev4-0045 ~]# rpm -q --whatprovides /opt/puppetlabs/bin/facter
puppet-agent-6.13.0-1.el7.x86_64

http://mirror.grid.uchicago.edu/pub/puppet6/7/x86_64/ - here is location for puppet-agent rpm @shailesh-vaidya For License info I have added link in above template.

[shailesh-vaidya]

@vaibhavparatwar Thanks for the details. So we are planning to use puppet-agent instead of facter package. Can you please confirm. In that case, we need to update package name in PR and also at https://github.com/Seagate/cortx-hare/blob/main/hare.spec#L50

[vaibhavparatwar]

@vaibhavparatwar Thanks for the details. So we are planning to use puppet-agent instead of facter package. Can you please confirm. In that case, we need to update package name in PR and also at https://github.com/Seagate/cortx-hare/blob/main/hare.spec#L50

Done for this patch

[vaibhavparatwar]

@johnbent could you please review and approve PR?

[vaibhavparatwar]

@vaibhavparatwar Thanks for the details. So we are planning to use puppet-agent instead of facter package. Can you please confirm. In that case, we need to update package name in PR and also at https://github.com/Seagate/cortx-hare/blob/main/hare.spec#L50

Done for this patch

Seagate/cortx-hare#1669 created PR for hare.spec file @shailesh-vaidya

[vaibhavparatwar]

Please ensure that download location and rpms are shard with the RE team.

Done @ujjwalpl

[shailesh-vaidya]

Need to link http://cortx-storage.colo.seagate.com/releases/cortx/third-party-deps/centos/centos-7.8.2003-2.0.0-8/ to http://cortx-storage.colo.seagate.com/releases/cortx/third-party-deps/centos/centos-7.8.2003-2.0.0-latest/ before merging this PR.

Created custom build -

@vaibhavparatwar - Please validate http://cortx-storage.colo.seagate.com/releases/cortx/github/integration-custom-ci/centos-7.8.2003/custom-build-1896/

Test RPM installation and it's working fine.

[root@79e6a25481eb ~]# rpm -qa cortx-prereq puppet-agent
puppet-agent-6.13.0-1.el7.x86_64
cortx-prereq-2.0.0-1896_git8af03b0_el7.x86_64

[root@79e6a25481eb ~]# /opt/puppetlabs/bin/facter --version
3.14.8 (commit 4339472f441868ecdae694ffc71e7c8ed0fc24e3)

[root@79e6a25481eb ~]# yum provides facter
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: yum.tamu.edu
 * extras: mirrors.xtom.com
 * updates: repos-lax.psychz.net
puppet-agent-6.13.0-1.el7.x86_64 : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, and hiera.
Repo        : @cortx-storage.colo.seagate.com_releases_cortx_github_integration-custom-ci_centos-7.8.2003_custom-build-1896_3rd_party_
Matched from:
Provides    : facter >= 1:3.0.0