Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

Data overlapping in train/test split #8

Open
notonlyvandalzzz opened this issue Apr 10, 2019 · 1 comment
Open

Data overlapping in train/test split #8

notonlyvandalzzz opened this issue Apr 10, 2019 · 1 comment

Comments

@notonlyvandalzzz
Copy link

Current version of predict function creates overlapping batch 1st element' indexes for train and test X and y_history tensors. Last item from X in train is first item in X in test. And due to mentioned in issue #4 gap between y_hist and y_targ there is one sequence missing in last chunk of splitted y_pred: i.e. we have dummy dataset with numbers as targs from 1 to 60, out last item in last batch would be 58 with y_targ = [60] leaving time window with 59 number out of party

@natezhenghy
Copy link

Confirm this post. There are several mistakes in the indexing in the code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants