Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended feature: Table-like Editor #2

Closed
claudiu-marginean opened this issue Sep 26, 2017 · 11 comments
Closed

Recommended feature: Table-like Editor #2

claudiu-marginean opened this issue Sep 26, 2017 · 11 comments
Assignees

Comments

@claudiu-marginean
Copy link

I like the fact that it validates and highlight into in CSV files.
But I was looking to the table like editor that is present in PhpStorm.

Maybe you can enable it by default and use it in this extension ;)

https://www.jetbrains.com/help/phpstorm/editing-csv-and-similar-files-in-table-format.html

@SeeSharpSoft
Copy link
Owner

Yes, I am aware of this feature for the non-community edition of JetBrains IDEs (also available in IntelliJ IDEA Ultimate - https://www.jetbrains.com/help/idea/editing-csv-and-similar-files-in-table-format.html).

Enabling the table like editor through this plugin is for obvious reasons not possible.

Said this, contributions providing a similar functionality without violating the IP of JetBrains are always welcome! ;)

@JulianRaya
Copy link

If you don't mind me asking, what are the "obvious reasons" that make table like editor not possible?

@SeeSharpSoft
Copy link
Owner

I pointed it out just in the next sentence...

But let me be straight: The database plugin, that is providing this feature to a bunch of JetBrains IDEs, is not part of the IntelliJ Community edition, it is the core component of JetBrains DataGrip. It is neither open source nor does it come with a "do-whatever-you-like" licensing model - I cannot afford the rightful lawsuit when distributing this ~40 MB library as part of my ~100 KB plugin... ;)

@JulianRaya
Copy link

Woah, that's lame of them.
Is this the same when developing plugins for the full version? Because there still seems to be a lack of useful functionality in most plugins, and the point you make seems to be a likely reason for that.

@SeeSharpSoft
Copy link
Owner

SeeSharpSoft commented Sep 30, 2017

No, there is nothing lame about it. You can develop and contribute functionality that you would like to see, there are no restrictions. Just don't "contribute" other peoples work, that would be lame!

@opticyclic
Copy link

Is there any preference over what framework or control is used to create the table?
e.g. Is something like this using JavaFX going to be OK https://community.oracle.com/message/10731570

Or just use swing JTable?

Or something else?

@SeeSharpSoft
Copy link
Owner

@opticyclic For me the most important requirement is that it fits well in the IntelliJ framework and the already existing editor/UI API. I haven’t digged into this part yet so I can’t name which UI components are suppossed to be used (or if there are any at all).

When I think about this feature it should be an alternative editor view (like the second tab of DataGrip) but without providing additional features that would be only available in this view.
For me personally the benefit of CSV is having the data in a pure text format. The table representation or even editor is quite nice in certain situations - but having a good text editor experience for CSV in general is IMO much more benefical and should stay in the focus of this plugin.

@JThoennes
Copy link

For me it is OK, that part of functionality is provided by core components and only visible if I switch to the Ultimate IDE.
But this should be clearly pointed out in the docs:

  • What works in the Community Edition?
  • What works in the Ultimate Edition?

Thanks!

@SeeSharpSoft
Copy link
Owner

@JThoennes This is a private project, I am doing it all in my spare time. This plugin is not related in any way to the "Edit as table..." functionality from the Ultimate Edition/DataGrip - I pointed it out several times, e.g. in the docs and in the plugin description itself and added links to the JetBrains component for further reading.

The functionality of this plugin is outlined in the docs as well as in the plugin description. All functions and benefits provided by this plugin are fully available in both, the Ultimate and the Community Edition - and in many other JetBrains IDEs like PyCharm, WebStorm, PhpStorm, etc without any restrictions.

@flomock
Copy link

flomock commented Aug 2, 2018

Hey thank you for the cool plugin, if've recently seen a feature in visual studio code were every 10 columns get different colors. In my opinion this should not be to hard to implement and really helps for a quick overview of the data.
thank you for your work

@SeeSharpSoft SeeSharpSoft changed the title Recommended feature Recommended feature: Table-like Editor Aug 2, 2018
@SeeSharpSoft SeeSharpSoft self-assigned this Sep 27, 2018
@SeeSharpSoft
Copy link
Owner

I am happy to announce that CSV Plugin 2.* features a table-like editor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants