Migrate to new ECMA class fields #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all keys will be declared now, this is necessary. Undefined is only possible if caller has not declared a value on input. Note that `nulls` are still valid inputs and are considered changes in most cases.
bryanjnelson
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opts in to the new (and future default) functionality.
This actually tells TS to emit properties at runtime.
This is opt-in because it's a breaking change for places we "override" a property.
We do this to narrow the parent type to a stricter one or just to declare a decorator.
With this new functionality, these spots would actually override the parents initial property.
Technically for us though it doesn't make a difference.
This TS says these are errors unless we give an initial value to these override spots.
Marking them as
declaremeans no new runtime property will be emitted, and it's just the parent class's property that will be used. Which makes sense and would be what we want if it actually mattered (if these weren't just shapes).Because these properties are non emitted to runtime, we probably could replace the
static Propsdeclarations in favor of this. But I'll leave that for a future PR.┆Issue is synchronized with this Monday item by Unito