-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Engagement filters to nest into Projects & Languages #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🗞 GraphQL SummaryView schema changes@@ -1466,8 +1466,12 @@
statusModifiedAt: SecuredDateTime!
}
input EngagementFilters {
+ language: LanguageFilters
+ project: ProjectFilters
+ status: [EngagementStatus!]
+
"""Only engagements matching this type"""
type: String
}
@@ -1588,8 +1592,14 @@
"""Based on the language's sensitivity"""
sensitivity: Sensitivity!
}
+input EthnologueLanguageFilters {
+ code: String
+ name: String
+ provisionalCode: String
+}
+
input ExecuteProgressReportTransitionInput {
"""Any additional user notes related to this transition"""
notes: RichText
@@ -2464,8 +2474,9 @@
total: Int!
}
input LanguageFilters {
+ ethnologue: EthnologueLanguageFilters
isDialect: Boolean
isSignLanguage: Boolean
"""Is a Least Of These partnership"""
@@ -2477,8 +2488,9 @@
"""
Only languages that are (not) in the "Preset Inventory"
"""
presetInventory: Boolean
+ registryOfDialectsCode: String
"""Only languages with these sensitivities"""
sensitivity: [Sensitivity!]
}
|
CarsonF
force-pushed
the
eng-nested-project-filters
branch
5 times, most recently
from
June 20, 2024 13:55
4115774
to
8a52689
Compare
It is repeated twice now in the current query which already matches the project, but another entry point could not have applied that filter. I don't think it is double the work for the DB.
CarsonF
force-pushed
the
eng-nested-project-filters
branch
from
June 20, 2024 21:19
8a52689
to
6fa2680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.