Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2167 #1113

Closed
wants to merge 5 commits into from
Closed

Fix 2167 #1113

wants to merge 5 commits into from

Conversation

elisabeth-sorrell
Copy link
Collaborator

@elisabeth-sorrell elisabeth-sorrell commented Apr 29, 2022

API PR: SeedCompany/cord-api-v3#2354
fixes #2167

┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466500749

Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need to fix lint error

@elisabeth-sorrell
Copy link
Collaborator Author

I've run yarn lint and yarn type-check and didn't find any errors....?

@CarsonF
Copy link
Member

CarsonF commented May 12, 2022

Hmm yeah idk why CI cannot find the artifact. Maybe a rebase on develop would fix it and would be good in general?

@elisabeth-sorrell
Copy link
Collaborator Author

Could it be because the API PR is either stale or had a failed build?

@sethmcknight
Copy link
Member

This lived to the end of its lifetime and died

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants