Make Products Changeset Aware #1142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Also note that I put icons on the right instead of the left. I thought it went better with the flow of how the props are displayed, instead of changing margins on a changeset (the icon overlaps the label when it's on the left.) |
CarsonF
requested changes
Aug 16, 2022
elisabeth-sorrell
force-pushed
the
addChangesetToProducts
branch
2 times, most recently
from
4ac1b2c
to
cf2760a
Compare
…uts of create and edit to have the correct variables for the CreateInput
…sName in addition to the classes.root
…ngesetId) if it was created in a changeset, but route to just the engagement id if not in a changeset
…e you can control what side of the wrapped component the icon goes on, with the default being the left side of the component
…with a ChangesetBade with mode depending on whether that item is added or removed, rendering each prop list Item according to the render function of the param
…function wraps the value with whatever the 'parent' component passes in. Have the simple props in the ProductDetail wrap the value with a ChangesetPropertyBadge, and use the new ChangesetPropertyList for the list props
elisabeth-sorrell
force-pushed
the
addChangesetToProducts
branch
from
cf2760a
to
093b41b
Compare
CarsonF
reviewed
Aug 16, 2022
|
This lived to the end of its lifetime and died |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API PR: SeedCompany/cord-api-v3#2471
┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466494554