Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode graphql updates #1438

Closed
wants to merge 3 commits into from
Closed

Vscode graphql updates #1438

wants to merge 3 commits into from

Conversation

willdch
Copy link
Contributor

@willdch willdch commented May 2, 2023

Added a .graphqlrc.yaml file needed for the recommended Graphql extensions to give better Graphql syntax highlighting, auto-completion and go to definition support.

@willdch willdch requested a review from CarsonF as a code owner May 2, 2023 20:36
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extrapolate review requests from here please
https://github.com/SeedCompany/seed-api/pull/428

@willdch willdch requested a review from CarsonF July 11, 2023 23:47
@@ -1,2 +1,3 @@
PORT=3001
CORD_URL=https://api.dev.cordfield.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add another env var for the same purpose. The one below this is fine.

Suggested change
CORD_URL=https://api.dev.cordfield.com

endpoints:
default:
url: ${CORD_URL}/graphql
documents: src/**/*.graphql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
documents: src/**/*.graphql
documents: src/**/*.graphql

@@ -1,6 +1,9 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethmcknight
Copy link
Member

This lived to the end of its lifetime and died

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants