Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: List supported Python versions #1591

Merged
merged 2 commits into from
Mar 4, 2024
Merged

docs: List supported Python versions #1591

merged 2 commits into from
Mar 4, 2024

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Feb 28, 2024

Python 3.8 is due to reach its scheduled upstream end-of-life in October 2024.

In preparation for this, we're marking support for this version as deprecated. It's still available, but will be removed in a future version.

@jesse-c jesse-c added the documentation Improvements or additions to documentation label Feb 28, 2024
@jesse-c jesse-c requested a review from sakoush February 28, 2024 14:25
@jesse-c jesse-c self-assigned this Feb 28, 2024
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably establish whether mlserver supports py11 and py12

@jesse-c
Copy link
Contributor Author

jesse-c commented Feb 29, 2024

@sakoush: I was thinking about that. I did some brief testing, and had some dependency installation failures on Python 3.11.8. Happy to update it to say that it's "untested" or something like that.

wdyt?

@sakoush
Copy link
Member

sakoush commented Feb 29, 2024

@sakoush: I was thinking about that. I did some brief testing, and had some dependency installation failures on Python 3.11.8. Happy to update it to say that it's "untested" or something like that.

wdyt?

yes we need to reflect status and perhaps also add an issue to investigate why mlserver doesnt work on py3.11.

@jesse-c
Copy link
Contributor Author

jesse-c commented Feb 29, 2024

I've added mentions for 3.11 and 3.12 in this change.

@RafalSkolasinski
Copy link
Contributor

As far as I understand #1603 removed support for Python 3.8.
Because of

python = ">=3.9,<3.12"

it will not be able to use it with Python 3.8 so it is not deprecated but removed

@jesse-c
Copy link
Contributor Author

jesse-c commented Mar 1, 2024

@RafalSkolasinski: This PR was opened before that, so I'll update this now.

@jesse-c
Copy link
Contributor Author

jesse-c commented Mar 1, 2024

@RafalSkolasinski: Done! Thank you for the reminder. 🙏🏻

Update: It's not showing up yet in the PR view here, but you can see it on my branch. Hopefully it'll show up soon.

@jesse-c
Copy link
Contributor Author

jesse-c commented Mar 1, 2024

@RafalSkolasinski: It's showing up now!

@jesse-c jesse-c merged commit 62e1d4e into SeldonIO:master Mar 4, 2024
18 of 20 checks passed
@jesse-c jesse-c deleted the supported-py-versions branch March 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants