Review status field for CRD #83
Comments
|
Fixed by various updated. Can create new issue as we review status field contents. |
agrski
added a commit
that referenced
this issue
Dec 2, 2022
* Refactor agent flag & env handling to new CLI file in main package * Refactor agent signal handler to function * Whitespace and typos * Format long lines + fix typos * Whitespace * Add env-handling file for agent CLI * Refactor update-from-env logic into named functions * Fix type in function * Refactor port-handling to simplify & stay DRY * Refactor remaining update-from-env logic to functions * Refactor flag-handling to new 'args' file This completes the separation of config sources: flags are handled in one file, env vars are handled in another, and the logic to combine these is encapsulated within another (the 'CLI'). Should we add support for config files in the future, it should be obvious how to define such support and where to add the merging logic. Doing so should require clean, minimal changes in a small number of places. * Move function closer to (only) usage * Rename files & functions for legibility * Fix typo setting wrong var from env * Refactor remaining flag-handling logic to 'flags' file from CLI This ensures that all flag-handling is done as a single, logical unit. Consumers can then use the vars set from flags as appropriate. * Move functions for visibiliity * Rename arg/flag vars for export This will allow for moving the CLI-handling logic to a subpackage and controlling the exposed data. For example, some vars are purely for internal use whilst parsing arguments, but right now it's not clear that this is the case, which is confusing and error-prone for users. * Refactor CLI handling to subpackage * Remove unnecessary use of function * Refactor function from subpackage to align with usage * Fix linting/fmt issues * Restrict visibility of internal vars in agent CLI * Restrict visibility of internal vars in agent CLI * Normalise capabilities list by trimming whitespace from all entries * Integrate Prom metrics changes into agent CLI Tidy up after merging Prometheus metrics changes from 'master'. * Restrict visibility of default port numbers These are used exclusively within the argument-handling logic of the CLI, so can be kept as private constants. * Fix typos - use vars from CLI subpackage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add top level state to show when seldonDeployment is running as normal? replicasAvailable = replicas for each predictor?
The text was updated successfully, but these errors were encountered: