Tls istio ingress example

[omerfsen]

What this PR does / why we need it:

Add Istio SSL/TLS Ingres examples.

Which issue(s) this PR fixes:

It does not fix anything but adds a new feature

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[seldondev]

Hi @omerfsen. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[ryandawsonuk]

Is there any need to commit the Seldon-ssl-gateway.yaml file in notebooks/resources ? Not seeing where that’s referenced. Otherwise looks all good and would be happy to approve.

[omerfsen]

I can add it a reference but it can be there only for example so someone that picks that can use it. Because sometimes a seperate file would be useful as a seperate yaml file instead of embedding it on the document ( md file).

[ryandawsonuk]

Also just occurred to me that maybe we should that this is one way and an alternative way to manage the secret is with cert-manager

[omerfsen]

Cert manager is adding to much complexity for a simple setup. I could write one but it requires more commands and for this it would be simply too much overhead.

My suggestion would be to implement it afterwards with its own PR. I can gladly work after this one merged.

[ryandawsonuk]

Yeah I don't mean to include a cert-manager example. I was just thinking we could mention that it's an alternative. So instead of saying To create self-signed certificate we could say Assuming we're not using [cert-manager](https://istio.io/latest/docs/ops/integrations/certmanager/) then create self-signed certificate with

[omerfsen]

Ok got it. Made your requested change just now

[ryandawsonuk]

/lgtm
/approve

[ryandawsonuk]

/ok-to-test

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Mon Aug 10 13:33:16 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2255/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2255 --build=1

[seldondev]

Mon Aug 10 13:33:17 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2255/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2255 --build=2

[ryandawsonuk]

/test this

[seldondev]

Mon Aug 10 14:04:07 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2255/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2255 --build=3

[ryandawsonuk]

/test this

[seldondev]

Mon Aug 10 14:39:02 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2255/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2255 --build=4