Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.uber.org/zap from 1.15.0 to 1.16.0 in /executor #2491

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps go.uber.org/zap from 1.15.0 to 1.16.0.

Release notes

Sourced from go.uber.org/zap's releases.

v1.16.0

Bugfixes:

  • #828[]: Fix missing newline in IncreaseLevel error messages.
  • #835[]: Fix panic in JSON encoder when encoding times or durations without specifying a time or duration encoder.
  • #843[]: Honor CallerSkip when taking stack traces.
  • #862[]: Fix the default file permissions to use 0666 and rely on the umask instead.
  • #854[]: Encode <nil> for nil Stringer instead of a panic error log.

Enhancements:

  • #629[]: Added zapcore.TimeEncoderOfLayout to easily create time encoders for custom layouts.
  • #697[]: Added support for a configurable delimiter in the console encoder.
  • #852[]: Optimize console encoder by pooling the underlying JSON encoder.
  • #844[]: Add ability to include the calling function as part of logs.
  • #843[]: Add StackSkip for including truncated stacks as a field.
  • #861[]: Add options to customize Fatal behaviour for better testability.

Thanks to @SteelPhase, @tmshn, @lixingwang, @wyxloading, @moul, @segevfiner, @andy-retailnext and @jcorbin for their contributions to this release.

#629: uber-go/zap#629 #697: uber-go/zap#697 #828: uber-go/zap#828 #835: uber-go/zap#835 #843: uber-go/zap#843 #844: uber-go/zap#844 #852: uber-go/zap#852 #854: uber-go/zap#854 #861: uber-go/zap#861 #862: uber-go/zap#862

Changelog

Sourced from go.uber.org/zap's changelog.

1.16.0 (1 Sep 2020)

Bugfixes:

  • #828[]: Fix missing newline in IncreaseLevel error messages.
  • #835[]: Fix panic in JSON encoder when encoding times or durations without specifying a time or duration encoder.
  • #843[]: Honor CallerSkip when taking stack traces.
  • #862[]: Fix the default file permissions to use 0666 and rely on the umask instead.
  • #854[]: Encode <nil> for nil Stringer instead of a panic error log.

Enhancements:

  • #629[]: Added zapcore.TimeEncoderOfLayout to easily create time encoders for custom layouts.
  • #697[]: Added support for a configurable delimiter in the console encoder.
  • #852[]: Optimize console encoder by pooling the underlying JSON encoder.
  • #844[]: Add ability to include the calling function as part of logs.
  • #843[]: Add StackSkip for including truncated stacks as a field.
  • #861[]: Add options to customize Fatal behaviour for better testability.

Thanks to @SteelPhase, @tmshn, @lixingwang, @wyxloading, @moul, @segevfiner, @andy-retailnext and @jcorbin for their contributions to this release.

Commits
  • 404189c Prepare release v1.16.0 (#863)
  • d0a4b9e newFileSink: use normatve 0666 default perm to OpenFile (#862)
  • 217b2cb Add options to customize Fatal behaviour for better testability (#861)
  • be2be86 Update Stringer panic check to look like stdlib (#857)
  • 663c590 Show "<nil>" for nil Stringer. (#854)
  • 2657839 Honor CallerSkip when taking stack traces & add the StackSkip field (#843)
  • 2314926 Add New Function Log Entry (#844)
  • 639461d consoleEncoder: put cloned jsonEncoder back to pool (#852)
  • 53a3870 Support configurable delimiter for console encoder (#697)
  • 275c926 Added zapcore.TimeEncoderOfLayout (#629)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.15.0...v1.16.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 28, 2020
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@adriangonz
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Tue Sep 29 13:21:39 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2491/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2491 --build=2

@seldondev
Copy link
Collaborator

Tue Sep 29 13:21:38 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2491/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2491 --build=1

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Sep 29 13:52:40 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2491/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2491 --build=3

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Sep 29 14:58:38 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2491/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2491 --build=4

@adriangonz
Copy link
Contributor

/cc @RafalSkolasinski

Is this good to approve @RafalSkolasinski? Do you expect any potential issues?

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Oct 1 08:26:07 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2491/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2491 --build=6

@seldondev
Copy link
Collaborator

Thu Oct 1 08:26:07 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2491/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2491 --build=5

@seldondev seldondev merged commit 472ca7a into master Oct 1, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/go_modules/executor/go.uber.org/zap-1.16.0 branch October 1, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants