Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build_all_local.sh script to use correct gpu-related scripts #2510

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix build_all_local.sh script to use correct gpu-related scripts #2510

merged 1 commit into from
Oct 1, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Oct 1, 2020

What this PR does / why we need it:

Wrong name of script was referenced and because of that new gpu image has not been built.
This fixes bug not caught in #2509.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@seldondev
Copy link
Collaborator

Thu Oct 1 12:46:18 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2510/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2510 --build=1

@seldondev
Copy link
Collaborator

Thu Oct 1 12:46:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2510/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2510 --build=2

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants