Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to kafka chart #2516

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

gsunner
Copy link
Contributor

@gsunner gsunner commented Oct 2, 2020

What this PR does / why we need it:
Fix a bug in the helm charts build/publishing makefile

Which issue(s) this PR fixes:
Fixes #2502

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Fri Oct 2 10:36:10 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2516/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2516 --build=2

@seldondev
Copy link
Collaborator

Fri Oct 2 10:36:19 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2516/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2516 --build=1

@gsunner
Copy link
Contributor Author

gsunner commented Oct 2, 2020

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gsunner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 117fed7 into SeldonIO:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update helm publishing Makefile for seldon-core-kafka chart removal
2 participants