Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alibi 0.5.5 #2571

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Update to Alibi 0.5.5 #2571

merged 1 commit into from
Oct 23, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Updates Alibi wrapper to use Alibi 0.5.5

Also:

  • Fixes Tensorflow proto issue with image explainer grpc call
  • Updates to ensure shap 0.36

Which issue(s) this PR fixes:

Fixes #2562

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

You need to build your Alibi explainer artifacts with python 3.6.8 to ensure the dill files can be loaded correctly. 

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Thu Oct 22 12:25:12 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2571/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2571 --build=2

@seldondev
Copy link
Collaborator

Thu Oct 22 12:25:21 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2571/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2571 --build=1

@axsaucedo
Copy link
Contributor

/approve
/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Thu Oct 22 16:33:43 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2571/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2571 --build=4

@seldondev
Copy link
Collaborator

Thu Oct 22 16:33:50 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2571/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2571 --build=3

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Oct 22 18:19:16 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2571/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2571 --build=5

@seldondev
Copy link
Collaborator

@cliveseldon: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 6994116 link /test integration
notebooks 6994116 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox
Copy link
Contributor Author

@axsaucedo all failures flaky and not explainer focused. Shall we merge?

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit 2f6b3d7 into SeldonIO:master Oct 23, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seldon Core explainers to use alibi v0.5.5
3 participants