-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seldon C++ wrapper #2639
Seldon C++ wrapper #2639
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sat Nov 14 22:44:25 UTC 2020 impatient try |
Sat Nov 14 22:44:34 UTC 2020 impatient try |
Sun Nov 15 08:35:34 UTC 2020 impatient try |
Sun Nov 15 08:35:37 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really amazing @axsaucedo! I've added a couple comments, mainly around docs (there seem to be some missing links). Other than that, this looks great!
Addressed all comments, should be good to go 👍 |
Tue Nov 17 07:19:40 UTC 2020 impatient try |
Tue Nov 17 07:19:46 UTC 2020 impatient try |
Tue Nov 17 07:26:20 UTC 2020 impatient try |
Tue Nov 17 07:26:25 UTC 2020 impatient try |
/approve Looks great @axsaucedo ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Nov 17 10:07:51 UTC 2020 impatient try |
Tue Nov 17 10:08:04 UTC 2020 impatient try |
Adds C++ wrapper, these two examples show the functionality:
Current features:
Outstanding (separate PR):