-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sideEffects to Webhooks to allow Dry Runs #2651
Conversation
Mon Nov 16 15:29:31 UTC 2020 impatient try |
Mon Nov 16 15:29:31 UTC 2020 impatient try |
@@ -8105,10 +8105,10 @@ spec: | |||
type: object | |||
endpoint: | |||
properties: | |||
grpc_port: | |||
grpcPort: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change of name not a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - this should have been in #2574
Looks like regeneration of the CRD was not done.
/test integration |
Tue Nov 17 08:36:24 UTC 2020 impatient try |
Thu Nov 19 15:08:54 UTC 2020 impatient try |
Thu Nov 19 15:09:03 UTC 2020 impatient try |
/test integration |
Thu Nov 19 15:29:23 UTC 2020 impatient try |
/test integration |
Fri Nov 20 14:46:57 UTC 2020 impatient try |
/test integration |
Tue Dec 1 19:05:32 UTC 2020 impatient try |
/test lint |
/approve |
Tue Dec 1 19:08:31 UTC 2020 impatient try |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Dec 1 21:01:05 UTC 2020 impatient try |
Tue Dec 1 21:01:19 UTC 2020 impatient try |
What this PR does / why we need it:
sideEffects=None
to Webhooks which allows dry-runs to be made from kubectlsideEffects
Which issue(s) this PR fixes:
Fixes #2648
Special notes for your reviewer:
Does this PR introduce a user-facing change?: