Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sideEffects to Webhooks to allow Dry Runs #2651

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Add sideEffects to Webhooks to allow Dry Runs #2651

merged 3 commits into from
Dec 1, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Adds sideEffects=None to Webhooks which allows dry-runs to be made from kubectl
  • Updates controller-gen to 0.2.9 which added annotation for sideEffects

Which issue(s) this PR fixes:

Fixes #2648

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

Mon Nov 16 15:29:31 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=1

@seldondev
Copy link
Collaborator

Mon Nov 16 15:29:31 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=2

@@ -8105,10 +8105,10 @@ spec:
type: object
endpoint:
properties:
grpc_port:
grpcPort:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change of name not a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - this should have been in #2574
Looks like regeneration of the CRD was not done.

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Nov 17 08:36:24 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=3

@seldondev
Copy link
Collaborator

Thu Nov 19 15:08:54 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=4

@seldondev
Copy link
Collaborator

Thu Nov 19 15:09:03 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=5

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Nov 19 15:29:23 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=6

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Nov 20 14:46:57 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=7

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Dec 1 19:05:32 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=8

@axsaucedo
Copy link
Contributor

/test lint

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Tue Dec 1 19:08:31 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=9

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Dec 1 21:01:05 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=10

@seldondev
Copy link
Collaborator

Tue Dec 1 21:01:19 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2651/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2651 --build=11

@seldondev seldondev merged commit 65b0504 into SeldonIO:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dry run deployment config
4 participants