-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security context to seldon-controller-manager deployment #2709
Conversation
Hi @mo-saeed. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/assign @SachinVarghese |
/assign @adriangonz |
/assign @cliveseldon |
/assign @ryandawsonuk |
Thank you @mo-saeed ! Would you be able to rebase? /cc @axsaucedo |
@axsaucedo I hope this pull request gets approved and merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@axsaucedo @ryandawsonuk @cliveseldon what is missing now? |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon, ryandawsonuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Dec 3 14:20:22 UTC 2020 impatient try |
Thu Dec 3 14:20:24 UTC 2020 impatient try |
The integration test should have been run as this PR does not work. See #2631 |
What this PR does / why we need it:
Add security context to seldon-controller-manager deployment so the pod doesn't fail when it tries to run as root user
Which issue(s) this PR fixes:
#2631
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: