Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security context to seldon-controller-manager deployment #2709

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

mo-saeed
Copy link
Contributor

What this PR does / why we need it:
Add security context to seldon-controller-manager deployment so the pod doesn't fail when it tries to run as root user

Which issue(s) this PR fixes:
#2631

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@seldondev
Copy link
Collaborator

Hi @mo-saeed. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@pierluigilenoci
Copy link

/assign @SachinVarghese

@pierluigilenoci
Copy link

/assign @adriangonz

@pierluigilenoci
Copy link

/assign @cliveseldon

@pierluigilenoci
Copy link

/assign @ryandawsonuk

@axsaucedo
Copy link
Contributor

Thank you @mo-saeed ! Would you be able to rebase?

/cc @axsaucedo

@seldondev seldondev added size/XS and removed size/S labels Dec 2, 2020
@mo-saeed
Copy link
Contributor Author

mo-saeed commented Dec 2, 2020

@axsaucedo I hope this pull request gets approved and merged soon.

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@pierluigilenoci
Copy link

@axsaucedo @ryandawsonuk @cliveseldon what is missing now?

@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cliveseldon,ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Dec 3 14:20:22 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2709/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2709 --build=2

@seldondev
Copy link
Collaborator

Thu Dec 3 14:20:24 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2709/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2709 --build=1

@seldondev seldondev merged commit 91d090c into SeldonIO:master Dec 3, 2020
@ukclivecox
Copy link
Contributor

The integration test should have been run as this PR does not work. See #2631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants